chore: change cdn. - #69
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 88.81% 88.81%
=======================================
Files 23 23
Lines 1707 1707
Branches 460 460
=======================================
Hits 1516 1516
Misses 54 54
Partials 137 137 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR migrates the CDN provider for @knighted/jsx from esm.sh to cdn.jsdelivr.net in the ESM demo file, while also pinning the version from @latest to 1.7.5.
Changes:
- Updated CDN provider from esm.sh to cdn.jsdelivr.net for @knighted/jsx imports
- Added performance optimizations (preconnect, dns-prefetch, modulepreload) for the new CDN
- Updated all references in titles, headings, and documentation text from "esm.sh" to generic "CDN" terminology
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b02f6a1 to
f1ca3fd
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| href="https://cdn.jsdelivr.net/npm/@knighted/jsx@1.7.6/lite/+esm" | ||
| /> | ||
| <link | ||
| rel="modulepreload" | ||
| href="https://cdn.jsdelivr.net/npm/@knighted/jsx@1.7.6/react/+esm" |
There was a problem hiding this comment.
The version is hardcoded to 1.7.6 in multiple modulepreload links. This creates a maintenance burden as these URLs will need manual updates on each release. Consider using a build-time variable replacement or documenting the need to update these references when releasing new versions.
| href="https://cdn.jsdelivr.net/npm/@knighted/jsx@1.7.6/lite/+esm" | |
| /> | |
| <link | |
| rel="modulepreload" | |
| href="https://cdn.jsdelivr.net/npm/@knighted/jsx@1.7.6/react/+esm" | |
| href="https://cdn.jsdelivr.net/npm/@knighted/jsx/lite/+esm" | |
| /> | |
| <link | |
| rel="modulepreload" | |
| href="https://cdn.jsdelivr.net/npm/@knighted/jsx/react/+esm" |
| * Tests the local E2E fixture to ensure that the current build works as expected. | ||
| */ | ||
| test.describe('esm demo via esm.sh', () => { | ||
| test.describe('esm demo via local dist fixture', () => { |
There was a problem hiding this comment.
The test suite name 'esm demo via local dist fixture' doesn't align well with the updated comment that says 'Tests the local E2E fixture'. Consider renaming the suite to something like 'e2e fixture via local dist' or 'local e2e fixture' to better reflect what's being tested.
| test.describe('esm demo via local dist fixture', () => { | |
| test.describe('local e2e fixture', () => { |
No description provided.